<html>
<head><meta charset="utf-8"><title>Tests for diagnostic fixes · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Tests.20for.20diagnostic.20fixes.html">Tests for diagnostic fixes</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="237823045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Tests%20for%20diagnostic%20fixes/near/237823045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Tests.20for.20diagnostic.20fixes.html#237823045">(May 07 2021 at 13:33)</a>:</h4>
<p>I can't seem to find any tests for the "Fill struct fields" quick fix, do we have any for that?</p>



<a name="237823086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Tests%20for%20diagnostic%20fixes/near/237823086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Tests.20for.20diagnostic.20fixes.html#237823086">(May 07 2021 at 13:33)</a>:</h4>
<p>If not, where should they go?</p>



<a name="237827547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Tests%20for%20diagnostic%20fixes/near/237827547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Tests.20for.20diagnostic.20fixes.html#237827547">(May 07 2021 at 14:01)</a>:</h4>
<p>Commenting the fix our shows the following failtures:</p>
<p>failures:<br>
    diagnostics::tests::range_mapping_out_of_macros<br>
    diagnostics::tests::test_fill_struct_fields_empty<br>
    diagnostics::tests::test_fill_struct_fields_enum<br>
    diagnostics::tests::test_fill_struct_fields_partial<br>
    diagnostics::tests::test_fill_struct_fields_self</p>



<a name="237827674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Tests%20for%20diagnostic%20fixes/near/237827674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Tests.20for.20diagnostic.20fixes.html#237827674">(May 07 2021 at 14:02)</a>:</h4>
<p>I think we probably should have one file per diagnostics, which contains both the diagnostics, the fix, and the tests</p>



<a name="237827729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Tests%20for%20diagnostic%20fixes/near/237827729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Tests.20for.20diagnostic.20fixes.html#237827729">(May 07 2021 at 14:02)</a>:</h4>
<p>basically, the same org we use for assists</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>